Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataframe embedder op factory and tune ferc-ferc model #3247

Merged
merged 26 commits into from
Jan 24, 2024
Merged

Conversation

zschira
Copy link
Member

@zschira zschira commented Jan 17, 2024

This PR gets the dataframe embedder op-factory working, and adds some tuning to the ferc-ferc model. It also adds some minor tooling to configure models using yaml files.

@zschira zschira requested a review from katie-lamb January 17, 2024 15:20
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (f4f2470) 92.6% compared to head (ae4002c) 92.6%.
Report is 7 commits behind head on main.

Files Patch % Lines
...rc/pudl/analysis/record_linkage/embed_dataframe.py 91.5% 5 Missing ⚠️
src/pudl/analysis/record_linkage/model_helpers.py 87.5% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3247     +/-   ##
=======================================
- Coverage   92.6%   92.6%   -0.0%     
=======================================
  Files        143     144      +1     
  Lines      12979   13056     +77     
=======================================
+ Hits       12025   12096     +71     
- Misses       954     960      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zaneselvans zaneselvans mentioned this pull request Jan 18, 2024
8 tasks
@zaneselvans zaneselvans added the ccai Tasks related to CCAI grant for entity matching label Jan 19, 2024
Copy link
Member

@katie-lamb katie-lamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Glad you got the dataframe embedder factory working. No requested changes on my end besides updating the xfail in test/validate/plants_steam_ferc1_test.py::test_dupe_years_in_plant_id_ferc1[ferc1_annual] to be a passing test.

@zschira zschira enabled auto-merge January 24, 2024 15:47
@zschira zschira merged commit ba5e9b4 into main Jan 24, 2024
12 checks passed
@zschira zschira deleted the fix_op_factory branch January 24, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ccai Tasks related to CCAI grant for entity matching
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants