-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dataframe embedder op factory and tune ferc-ferc model #3247
Conversation
This reverts commit 4f38401.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3247 +/- ##
=======================================
- Coverage 92.6% 92.6% -0.0%
=======================================
Files 143 144 +1
Lines 12979 13056 +77
=======================================
+ Hits 12025 12096 +71
- Misses 954 960 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Glad you got the dataframe embedder factory working. No requested changes on my end besides updating the xfail in test/validate/plants_steam_ferc1_test.py::test_dupe_years_in_plant_id_ferc1[ferc1_annual]
to be a passing test.
This PR gets the dataframe embedder op-factory working, and adds some tuning to the ferc-ferc model. It also adds some minor tooling to configure models using yaml files.