Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more service accounts to Workload Identity Federation #2273

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

jdangerx
Copy link
Member

@jdangerx jdangerx commented Feb 3, 2023

PR Overview

This adds a bunch of new service account associations to the WIF provider we set up earlier, so that other repos can also use WIF instead of credentials.

I've already run terraform apply here so the changes should be reflected within GCP already.

Note that the build-deploy-pudl and zenodo-cache-sync actions are triggered via schedule and workload_dispatch, so the versions on main are the ones that will run. Which means that they'll continue to use the old credentials jsons until this lands in main.

PR Checklist

@jdangerx jdangerx requested review from a team and zschira and removed request for a team February 3, 2023 21:05
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 85.7% // Head: 85.7% // No change to project coverage 👍

Coverage data is based on head (2f640b3) compared to base (149860f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2273   +/-   ##
=====================================
  Coverage   85.7%   85.7%           
=====================================
  Files         73      73           
  Lines       8997    8997           
=====================================
  Hits        7713    7713           
  Misses      1284    1284           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@zschira zschira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just browsed the terraform docs/got up to speed with the WIF work, and this looks good and reasonable to me!

@jdangerx jdangerx merged commit f37671e into dev Feb 7, 2023
@jdangerx jdangerx deleted the daz/add-more-sas-to-wif branch February 7, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants