Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old notebooks #2186

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Delete old notebooks #2186

merged 1 commit into from
Jan 10, 2023

Conversation

jdangerx
Copy link
Member

@jdangerx jdangerx commented Jan 6, 2023

PR Overview

Remove defunct notebooks that we do not intend to maintain. Future example-seekers should go to catalyst-cooperative/pudl-examples.

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues. @zaneselvans do I need to do this?
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 85.6% // Head: 85.6% // No change to project coverage 👍

Coverage data is based on head (11797bd) compared to base (dc39bdd).
Patch has no changes to coverable lines.

❗ Current head 11797bd differs from pull request most recent head 9ffbb43. Consider uploading reports for the commit 9ffbb43 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2186   +/-   ##
=====================================
  Coverage   85.6%   85.6%           
=====================================
  Files         73      73           
  Lines       8958    8958           
=====================================
  Hits        7674    7674           
  Misses      1284    1284           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zaneselvans
Copy link
Member

Did you check whether there was any documentation or code referring to these notebooks? Though I suspect that there wasn't since none of them could be getting deployed (they weren't included in the package_data that's included with the Python package)

@zaneselvans
Copy link
Member

@jdangerx I think these have been deprecated for a long time and we haven't had any public reference to them for ages, in which case release notes aren't necessary.

@jdangerx
Copy link
Member Author

jdangerx commented Jan 9, 2023

@zaneselvans none of these notebooks appear to be referred to, except for in this old closed ticket about modernizing them.

@jdangerx jdangerx force-pushed the john/delete-old-notebooks branch from 11797bd to 9ffbb43 Compare January 9, 2023 22:57
@jdangerx jdangerx requested a review from a team January 9, 2023 23:18
@jdangerx jdangerx merged commit db5ce8f into dev Jan 10, 2023
@jdangerx jdangerx deleted the john/delete-old-notebooks branch January 10, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants