Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Python 3.10 and update to modern syntax #1685

Merged
merged 6 commits into from
Jun 10, 2022
Merged

Require Python 3.10 and update to modern syntax #1685

merged 6 commits into from
Jun 10, 2022

Conversation

zaneselvans
Copy link
Member

@zaneselvans zaneselvans commented Jun 10, 2022 •
edited
Loading

Changes:

  • Require Python 3.10 and only run tests on that version.
  • Use pyupgrade and pep585-update to update syntax to 3.10 norms.
  • Switch Read The Docs build config to using mambaforge and Python 3.10.

zaneselvans
zaneselvans commented Jun 10, 2022
View reviewed changes
Copy link
Member Author

@zaneselvans zaneselvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly this is just syntax and dependency updates, nothing very exciting to review.

@zaneselvans zaneselvans changed the title Treat PUDL as an app not a library Require Python 3.10 and update to modern syntax Jun 10, 2022
@zaneselvans zaneselvans marked this pull request as ready for review June 10, 2022 23:17
bendnorman
bendnorman approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@bendnorman bendnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@zaneselvans zaneselvans merged commit 3c2e5f2 into dev Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendnorman bendnorman bendnorman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaneselvans @bendnorman