Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 176 and ATB archivers to not hardcode year #377

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Jul 4, 2024

Overview

Addresses part of #372.

What problem does this address?
With hardcoded years, we currently have to remember to check whether a new year of data is out. The monthly archiver runs won't capture new years of data released.

What did you change in this PR?
Removes hardcoded year from NREL ATB and EIA 176 archivers.

Testing

How did you make sure this worked? How can a reviewer verify this?
Run both archivers. Verify all years expected to download are successfully downloaded.

To-do list

Tasks

@e-belfer e-belfer self-assigned this Jul 4, 2024
@e-belfer e-belfer added eia176 EIA Form 176 natural gas sources and dispositions nrelatb NREL's Annual Technology Baseline data labels Jul 4, 2024
@e-belfer e-belfer requested a review from zaneselvans July 5, 2024 14:30
Copy link
Member

@zaneselvans zaneselvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Request for a bit more info in docstring.
  • Question about maybe a variable name that needs to be updated?

src/pudl_archiver/archivers/eia/eia176.py Show resolved Hide resolved
src/pudl_archiver/archivers/eia/eia176.py Show resolved Hide resolved
@e-belfer e-belfer requested a review from zaneselvans July 5, 2024 15:00
@e-belfer e-belfer merged commit aba3d11 into main Jul 5, 2024
3 checks passed
@e-belfer e-belfer deleted the fix-year-hardcodes branch July 5, 2024 15:12
@e-belfer e-belfer linked an issue Jul 8, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eia176 EIA Form 176 natural gas sources and dispositions nrelatb NREL's Annual Technology Baseline data
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve archivers and automated workflow to support faster data integration
2 participants