Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and fix GHA for early and final release data #374

Merged
merged 10 commits into from
Jul 5, 2024
Merged

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Jul 4, 2024

Overview

What problem does this address?
Now that #373 is merged, let's test it and fix it.

What did you change in this PR?
Get the right dataset, update various failures in how the workflow file was originally set up.

Testing

How did you make sure this worked? How can a reviewer verify this?
Run the workflow. If there is no new data, it shouldn't create a GH issue unless the check issue box is selected at workflow startup.

To-do list

Tasks

@e-belfer e-belfer self-assigned this Jul 4, 2024
@e-belfer e-belfer requested a review from zaneselvans July 5, 2024 11:59
@zaneselvans zaneselvans added the github_actions Pull requests that update GitHub Actions code label Jul 5, 2024
Copy link
Member

@zaneselvans zaneselvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions but nothing blocking.

Clean up copied comments

Co-authored-by: Zane Selvans <[email protected]>
@e-belfer e-belfer merged commit 1979147 into main Jul 5, 2024
3 checks passed
@e-belfer e-belfer deleted the fix-GHA-FR-ER branch July 5, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eia860 eia861 eia923 github_actions Pull requests that update GitHub Actions code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants