Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DinoMod] DinoLab missions #606

Merged
merged 16 commits into from
Jun 27, 2021
Merged

[DinoMod] DinoLab missions #606

merged 16 commits into from
Jun 27, 2021

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Jun 17, 2021

Summary

SUMMARY: [Mods] "DinoLab mission chain"

Purpose of change

Build DinoLab story, tie together new dino mutagen content, tee up eventual DinoLab project

Describe the solution

First mission for Dr. Yoshimi to get a chemistry set, reveals a (generic for now) lab and spawns a zombie dino there to fight. Second mission to get a recipe book at the existing field exhibit, spawns a zombie scientist and zombie dino to fight.

Describe alternatives you've considered

Just build the stupid lab already

Testing

Game loads no errors. Yoshimi spawn looks good now.
Screen Shot 2021-06-20 at 2 16 44 PM

Conversational flow is fixed.
First quest works, map spawns, monster and item spawn.
Screen Shot 2021-06-23 at 9 27 13 PM

Item works to end the quest correctly.
Second quest throws the right mission and the monsters looks good
Screen Shot 2021-06-20 at 2 21 43 PM

Additional context

“I've seen things you people wouldn't believe" -Bladerunner

@LyleSY
Copy link
Contributor Author

LyleSY commented Jun 20, 2021

Looks like Travis is strange. I'll try and test this current version in game before adding more.

@Coolthulhu
Copy link
Member

We're in the middle of a switch to github actions, since Travis no longer supports free builds for OSS projects: #609
Testing in your own version is always appreciated, though. Automatic tests and my own testing can only catch a part of the bugs.

@Coolthulhu
Copy link
Member

Alright, the switch is done. This PR is still a draft, is it supposed to be?

@LyleSY LyleSY marked this pull request as ready for review June 24, 2021 01:30
@Coolthulhu Coolthulhu self-assigned this Jun 27, 2021
@Coolthulhu
Copy link
Member

Dino exhibit looks really weird with all those indoor plants.

Screenshot from 2021-06-27 19-21-22

For some reason, Kiernan, his item and bio-op dino didn't spawn in 2 out of 3 tries. Might be a bug with update_mapgen rotations or something like that.

@Coolthulhu Coolthulhu merged commit b8350f9 into cataclysmbnteam:upload Jun 27, 2021
@LyleSY LyleSY deleted the patch-2 branch June 27, 2021 18:00
@LyleSY
Copy link
Contributor Author

LyleSY commented Jun 27, 2021

Ha, yeah the plants started as a bug, but we kind of liked them so kept them as a joke. Good call, I'll try and shut rotation off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants