Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): make max skill level limit configurable #5999

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

scarf005
Copy link
Member

Purpose of change (The Why)

after #3720, people wanted to train skill levels higher than 10. why not?

Describe the solution (The How)

made max skill configurable in debug settings. 1000 should probably be enough i guess.

Testing

image
image
image

  1. increase max skill level to 100
  2. set all skill level to 10
  3. kill hulks with rifle
  4. rifle level is increased

Additional context

discord talk: https://discord.com/channels/830879262763909202/830916451517857894/1331465767211892796

i can't run astyle because newer version doesn't support some options project uses.

Checklist

Mandatory

@scarf005 scarf005 changed the title feat: make max skill level limit configurable feat(UI): make max skill level limit configurable Jan 27, 2025
@github-actions github-actions bot added the src changes related to source code. label Jan 27, 2025
@scarf005 scarf005 force-pushed the feat/skill-level-option branch from 053f910 to 1c0fab8 Compare January 27, 2025 17:15
@github-actions github-actions bot added the tests changes related to tests label Jan 27, 2025
@scarf005 scarf005 requested a review from chaosvolt January 27, 2025 17:16
Copy link
Contributor

autofix-ci bot commented Jan 27, 2025

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR isn't my decision at all because we're opening Pandora's box full of unforeseen consequences and bugs that we may have to fix that I won't be able to fix.

So long as the main coders of the project are willing to accept that responsibility I can't object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code. tests changes related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants