-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(port,content): Day and Night, Dusk and Dawn for enchantment conditions #5871
feat(port,content): Day and Night, Dusk and Dawn for enchantment conditions #5871
Conversation
…/Cataclysm-BN into Day-and-Night-Spells
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
Slight correction: It's conditions for enchantments, not spells haha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
co-authored with Maleclypse from dda pull request CleverRaven/Cataclysm-DDA#51630
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Co-Authored-By
in the commit message.doc/
folder.Purpose of change
ports small elements of the following dda pr
Describe the solution
allows the use of
DAWN
,DUSK
,DAY
, andNIGHT
for use as conditional elements of enchantmentsDescribe alternatives you've considered
Testing
Additional context