-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(content, port): Port Directed push from DDA #5566
Conversation
When the push is directed Co-Authored-By: Curtis Merrill <[email protected]>
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
Wait fuck I accidentally removed debug dash. Let me just fix that... |
There we go, documentation obtained and debug-dash reinstated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok, @chaosvolt could you playtest it?
Hecc, was distracted yesterday and being dragged out today, will try to test when I get home @.@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And bit belatedly, looks good.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
Co-Authored-By
in the commit message.doc/
folder.Purpose of change
More spell effects available is always good, and the previous pushing behavior did not seem very nice to use.
Describe the solution
Ports CleverRaven/Cataclysm-DDA#44682
Describe alternatives you've considered
Seemed worth it, and like not doing it would just be a big headache
More atomic commits go brrr
Testing
Built once back when I had set it to be a cone area type, worked fine. I doubt that changing it to blast to better align with the DDA intentions (and to make more sense) is going to seriously break anything
Additional context
Apparently DDA jsonized both spell shape and simplified targeting fields at some point.
Debug spells provided for testing convenience. Documentation coming in just a minute or two :3