-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(port): Bionics can require another bionic #5484
Conversation
https: //github.com/CleverRaven/Cataclysm-DDA/pull/66996 Co-Authored-By: anoobindisguise <[email protected]>
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might first advise checking for professions that use hydraulic muscles and add the needed CBM to them, just to be safe.
or even better, maybe auto-add required bionics in following PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aight, looks good now, compiles and starting as a cyborg with the relevant CBMs doesn't do anything weird.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
Purpose of change
ports
Fixes #5455
Describe the solution
ports the dda change which can allow bionic A to require bionic B to already be installed prior to installation of Bionic A
Describe alternatives you've considered
Testing
Additional context