Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create our own implementation of bionics requiring other bionics #5455

Closed
RoyalFox2140 opened this issue Sep 29, 2024 · 0 comments · Fixed by #5484
Closed

Create our own implementation of bionics requiring other bionics #5455

RoyalFox2140 opened this issue Sep 29, 2024 · 0 comments · Fixed by #5484
Labels
enhancement src changes related to source code.

Comments

@RoyalFox2140
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

This PR. CleverRaven/Cataclysm-DDA#66996

I was looking to port it due to how few lines and how easy it looks, but our code has diverged heavily and we're lacking Character::is_installable So I don't even know how or if a 1:1 port works.

Describe the solution you'd like

Bionics should be capable of calling for other bionics in JSON to be installed first. Not only would this remove all hardcoded instances of us doing this (Micro-reactors, telescopic eyes have an NV upgrade I think unless I'm thinking of NEO Scav), and would let us add more on the JSON side with 0 effort. They used hydraulic muscles with titanium skeletal bracing for example.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement src changes related to source code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant