Port DDA's optimizations to cata_tiles::find_tile_looks_like + Skip and report duplicate tiles in tileset #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for tiles with same ids and different sizes causing rendering issues CleverRaven/Cataclysm-DDA#48819
Drat, it also broke sprite replacement mods. Will have to think of another solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Increase FPS
Expand on tileset correctness checks
Describe the solution
Port CleverRaven#44917.
That PR changed handling of tiles with same ids (while they used to be completely overwritten by the last such tile, after the change they somehow cause CleverRaven#48819). I don't quite get what's happening there, so as a workaround implemented a check for duplicate ids within a tileset (it seems to have fixed the issue).
Testing
Visually checked (with UDP and ChestHole16) tiles for:
FPS improvement - UDP, in a city, zoomed out:
Same place, RetroDays, zoomed out: