-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(content): Add Glock Auto-Sear(switch) #4831
Conversation
Adds Glock Switches
Updates glock switch desc and adds semi firing mode
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
The Glock 20 was recently added to the game, so make sure to include it as a valid tool and mod recipient |
It was just added 5 minutes ago I'm crying. |
Adds the Glock 20 to the auto-sear
Updated to add the Glock 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check if the other "auto switcher" for the AR guns is also in item groups (spawning somewhere) if so, add it into those lists alongside the AR one.
@@ -70,6 +70,27 @@ | |||
"mode_modifier": [ [ "DEFAULT", "auto", 6 ] ], | |||
"flags": [ "INSTALL_DIFFICULT" ] | |||
}, | |||
{ | |||
"id": "gswitch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe change it to glockswitch? Maybe we have a samey thing later also with the letter G.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'll do this in case I make more switches/sears in the future and they don't all start with a single letter.
Gets rid of a double space Co-authored-by: Viss Valdyr <[email protected]>
Change gswitch to glockswitch
Lightning links and Autosears do not naturally spawn form what I see, I'll leave adding them and glock switches to the spawn pool for another PR if that's okay. |
Definitely weird but not surprising that it doesn't spawn. I suppose I'll tinker with it in a followup in a bit then. |
could this be checked again? the PR is opened from main branch, which makes it harder to pull updates |
No one actually pays attention to what the checklist says... XD |
it should be, in order to prevent nasty branch issues |
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
Purpose of change
Describe the solution
Describe alternatives you've considered
Not making this PR.
Testing
Made the recipes, spawned all the parts ingame, made the Glock switch, added it to a gun, and fired it. There's a video up on Discord that shows it working.
Additional context