-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(content): Shocking flag #4561
Conversation
Added in the shocking json flag, changes to electrical weapons, electrified rapier, tonfa recipe adjustment. WIP.
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
Hmm. Question: did these need to be hardcoded in at all? I see nothing in this so far that can't be replicated using a mundane transform action? |
Undid the hardcode for the use actions, instead just added them in the json since that's way simpler.
No, no it did not. |
Co-authored-by: Chaosvolt <[email protected]>
Thanks for catching that, Chaos. |
Since the shock tonfa's hardcode was throwing errors, I decided to un-hardcode that too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just one case of a turn-off action still retaining active toggle and other stuff copied from the turn-on action, but also having a separate revert message could be an optional improvement if desired, so it doesn't just claim you flick the switch off automatically when it runs out of charges and reverts.
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
How about a shocking pride flag now? |
Added in the shocking json flag, changes to electrical weapons, electrified rapier, tonfa recipe adjustment.
Purpose of change
There was a FLAMING flag which made weapons deal bonus fire damage, but not a SHOCKING flag that made weapons deal bonus electrical damage.
Describe the solution
Added in the SHOCKING flag which is an electrical equivalent to the FLAMING flag. Adjusted electrical weapons to compensate, giving them transformations instead. Made tonfas autolearn, since they're not that amazing and they're basically just clubs with a prong coming out of them.
Describe alternatives you've considered
Testing
I've managed to get it down to only one error! If anyone can help me, please do.
Additional context
Checklist