Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): Rebalanced occurrences of some specials #3653

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

Vollch
Copy link
Contributor

@Vollch Vollch commented Nov 13, 2023

Summary

SUMMARY: Balance "Rebalanced occurrences of some specials"

Purpose of change

With latest changes some specials went way off balance, that an attempt to improve it.
For reference: context, documentation.
There might be more things which need adjustments, feedback welcome.

Describe the solution

Lakes changes:

  • All islands increased from 0-1 to 0-3, and untied from cities. Raw occurrences assumes a full lake overmap, so even with 0-3 lakes are desolated enough. And islands shouldn't care about cities at all.
  • Island prison got bigger min distance from city - it won't noticeable restrict uniq thing, and just makes sense. Chances slightly increased to compensate land\water normalization.
  • Marina become an uniq instead of 0-1, slightly increasing chances(50% to 75%), and also got more forgiving placement restrictions. We don't really care if it will be placed on bumpy coast, as long as edge is matching - inner terrain will be overridden anyway.
  • Lighthouse increased from 0-1 to 0-4. That's the only non-uniq lake special worth a visit, some buff won't hurt it.

Land changes:

  • Sugar House reduced from 0-10 to 0-4. That's a very bland special, which even paves a road to itself, just adding a mess for no good reason.
  • Airports nerfed from 50% to 35%. There's two of them and total 70% seems good enough. Airports are cool, it makes them a bit more valuable.
  • Refuge center nerfed from 75% to 50%. Huge ugly thing. Less is better.
  • Isherwood got bigger min distance from city. This abomination often bigger than cities, better put in wilderness.
  • Necropolist 33% -> 30%, Hub 01 33% -> 35%. Just rounding.

Describe alternatives you've considered

Leaving balancing to someone else.

Testing

Generated some overmaps.

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 13, 2023
@scarf005 scarf005 changed the title Rebalanced occurrences of some specials feat(balance): Rebalanced occurrences of some specials Nov 13, 2023
@scarf005
Copy link
Member

scarf005 commented Nov 13, 2023

a hecc, house palette error prevents other tests from running. ran local tests insteaed and they passed.
image

@scarf005 scarf005 added this pull request to the merge queue Nov 13, 2023
Merged via the queue into cataclysmbnteam:upload with commit ba3e7e1 Nov 13, 2023
6 of 14 checks passed
@Vollch Vollch deleted the special_occurrences branch November 25, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants