Misc UI changes/fixes from DDA 4 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 additions to martial arts style info Add skill fix for 'Close Quarters Battle CBM' Change skill order to player skill / required skill
Ideally, there would be two context: walking and driving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Port QoL changes and fixes to various UIs from DDA.
Describe the solution
Cherry-picked:
CleverRaven#44593
CleverRaven#42962
CleverRaven#44413
CleverRaven#44435 (excluding blood type, since BN doesn't have it)
CleverRaven#44599 (squashed with CleverRaven#44898)
CleverRaven#44741 (this should really get its own key in keybindings menu instead of being alternative function of
smash)CleverRaven#44842
CleverRaven#42607
Describe alternatives you've considered
Testing
Tried each change in-game. Didn't test failing location report & "use item" menu performance, but these are trivial.
Additional context
Apparently, hitting
Returnafter losing input focus makes github immediately open the PR...