Fix "bow" gunmod location not working #1569
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add warning in strict json mode
Summary
SUMMARY: Bugfixes "Fix 'bow' gunmod location not working"
Purpose of change
Fix #1526
Describe the solution
When a gun has skill type "archery", allow gunmods with "bow" as gun type as well.
Added a warning, currently only in strict mode, that "bow" is deprecated. All modders should have strict mode on for warnings like this.
Changed existing entries from "bow" to "archery".
Describe alternatives you've considered
Rewriting the hacky gunmod location thing to be properly verified and strongly typed.
While this would be a good idea, it would take extra work, then again even more to maintain compatibility with mods.
Dropping the "bow" location altogether and just printing warnings if neither skill nor item for the location exists.
Checking if there is at least one gun with given type which can receive this particular gunmod, warning if there isn't.
Testing
Additional context