Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "bow" gunmod location not working #1569

Merged
merged 2 commits into from
May 28, 2022
Merged

Fix "bow" gunmod location not working #1569

merged 2 commits into from
May 28, 2022

Conversation

Coolthulhu
Copy link
Member

Also add warning in strict json mode

Summary

SUMMARY: Bugfixes "Fix 'bow' gunmod location not working"

Purpose of change

Fix #1526

Describe the solution

When a gun has skill type "archery", allow gunmods with "bow" as gun type as well.

Added a warning, currently only in strict mode, that "bow" is deprecated. All modders should have strict mode on for warnings like this.
Changed existing entries from "bow" to "archery".

Describe alternatives you've considered

Rewriting the hacky gunmod location thing to be properly verified and strongly typed.
While this would be a good idea, it would take extra work, then again even more to maintain compatibility with mods.

Dropping the "bow" location altogether and just printing warnings if neither skill nor item for the location exists.

Checking if there is at least one gun with given type which can receive this particular gunmod, warning if there isn't.

Testing

  • Spawn recurve bow and arrow rest
  • Activate arrow rest
  • Should allow installing on bow
  • Should install properly on confirm

Additional context

@Coolthulhu Coolthulhu self-assigned this May 24, 2022
@Coolthulhu Coolthulhu merged commit a47ce63 into upload May 28, 2022
@olanti-p olanti-p deleted the bow-mod-fix branch March 24, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant