Draw lines of fire when aiming vehicle turrets #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it's readable and either "obviously correct", backed up by tests, or otherwise easy to verify it works, then yes. |
Coolthulhu
reviewed
Oct 29, 2020
| if( draw_turret_lines ) { | ||
| for( const vehicle_part *t : vturrets ) { | ||
| turret_data td = veh->turret_query( *t ); | ||
| if( td.in_range( dst ) ) { |
There was a problem hiding this comment.
It's a big ladder, could be more readable with some of the ifs inverted.
There was a problem hiding this comment.
True. I don't normally do this, but figured I'll be rewriting this part anyway at a later point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Draw lines of fire when aiming vehicle turrets"
Purpose of change
Describe the solution
Cherry-pick and/or adapt code from the mainline
Describe alternatives you've considered
Cherry-picking CleverRaven#39785 for the bugfixes first, but it had accumulated a billion merge conflicts/its own changes by now. I could try to port all of that to BN and make a big PR (3k-4k lines of C++) - if you're willing to have these changes / review them?
Testing
(On CURSES) Clicked on tiles at the edge of FoV to trigger the exploit - the path shows as dark grey
?signs.(On TILES and CURSES) Installed a bunch of turrets on a vehicle - aiming them draw individual trajectories, and pressing
ttoggles the display to avoid overcrowding.(On TILES) Tried aiming with a gun at a tile outside FoV - aiming cursor remains visible
Additional context