refactor: don't mutate string

cataclysmbnteam · Dec 5, 2024 · 4fe00c5 · 4fe00c5
1 parent d3f0485
commit 4fe00c5
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/item.cpp b/src/item.cpp
@@ -3024,13 +3024,13 @@ void item::book_info( std::vector<iteminfo> &info, const iteminfo_query *parts,
         const SkillLevel &skill = you.get_skill_level_object( book.skill );
         if( parts->test( iteminfo_parts::BOOK_SKILLRANGE_MAX ) ) {
             const std::string skill_name = book.skill->name();
-            std::string fmt = string_format( _( "Can bring <info>%s skill to</info> "
-                                                "<num>." ), skill_name );
+            const std::string fmt = string_format( _( "Can bring <info>%s skill to</info> "
+                                                   "<num>." ), skill_name );
             info.emplace_back( "BOOK", "", skill.can_train() ? fmt : colorize( fmt, c_brown ),
                                iteminfo::no_flags, book.level );
-            fmt = string_format( _( "Your current <stat>%s skill</stat> is <num>." ),
-                                 skill_name );
-            info.emplace_back( "BOOK", "", fmt, iteminfo::no_flags, skill.level() );
+            info.emplace_back( "BOOK", "",
+                               string_format( _( "Your current <stat>%s skill</stat> is <num>." ), skill_name ),
+                               iteminfo::no_flags, skill.level() );
         }
 
         if( book.req != 0 && parts->test( iteminfo_parts::BOOK_SKILLRANGE_MIN ) ) {