Fix/server should return better error codes when generating open ai images #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated AIImageInterfaceResponse to handle both success and failure cases. - Added error handling in OpenAIImageInterface.ts to check for HTTP 400 Bad Request responses. - Return a proper response to the user when provided parameters are not accepted by the selected model.
…request' fix: AIController.ts and AIImageInterface.ts now include a property to handle 'invalid_request'
…TTP 400 Bad Request responses.
TroyceGowdy
added
bug
KallynGowdy
requested changes
Dec 23, 2024
CHANGELOG.md
Outdated
| @@ -1,5 +1,17 @@ | |||
| # CasualOS Changelog | |||
|
|
|||
| ## V3.3.16 | |||
|
|
|||
| #### Date: TBA | |||
There was a problem hiding this comment.
@TroyceGowdy This should be "TBD" instead of "TBA". Our release script requires a specific format in order to work.
| span?.setStatus({ code: SpanStatusCode.ERROR }); | ||
|
|
||
| console.error( | ||
| `[OpenAIChatInterface] [${request.userId}] [generateImage]: Bad request: ${err.response.data.error.message}` |
There was a problem hiding this comment.
@TroyceGowdy This log should note "StabilityAIChatIngerface" instead of OpenAI.
fix: StabilityAIImageInterface.ts now returns 'StabilityAIChatIngerface' instead of 'OpenAIChatInterface'
KallynGowdy
approved these changes
Dec 23, 2024
KallynGowdy
requested changes
Dec 23, 2024
There was a problem hiding this comment.
@TroyceGowdy I just noticed that there are a couple build errors in the unit tests for the AI controller. Could you fix those too?
|
@TroyceGowdy Can you fix the test errors for |
KallynGowdy
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #565