fix(filter-sets): 404 on dashboard load (apache#17777)

casual-precision · Feb 7, 2022 · cbc861c · cbc861c
1 parent 592404d
commit cbc861c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/superset-frontend/src/dashboard/actions/nativeFilters.ts b/superset-frontend/src/dashboard/actions/nativeFilters.ts
@@ -204,8 +204,7 @@ export interface SetBootstrapData {
 }
 
 export const getFilterSets =
-  () => async (dispatch: Dispatch, getState: () => RootState) => {
-    const dashboardId = getState().dashboardInfo.id;
+  (dashboardId: number) => async (dispatch: Dispatch) => {
     const fetchFilterSets = makeApi<
       null,
       {
@@ -271,7 +270,7 @@ export const createFilterSet =
     dispatch({
       type: CREATE_FILTER_SET_COMPLETE,
     });
-    dispatch(getFilterSets());
+    dispatch(getFilterSets(dashboardId));
   };
 
 export const updateFilterSet =
@@ -308,7 +307,7 @@ export const updateFilterSet =
     dispatch({
       type: UPDATE_FILTER_SET_COMPLETE,
     });
-    dispatch(getFilterSets());
+    dispatch(getFilterSets(dashboardId));
   };
 
 export const deleteFilterSet =
@@ -329,7 +328,7 @@ export const deleteFilterSet =
     dispatch({
       type: DELETE_FILTER_SET_COMPLETE,
     });
-    dispatch(getFilterSets());
+    dispatch(getFilterSets(dashboardId));
   };
 
 export const SET_FOCUSED_NATIVE_FILTER = 'SET_FOCUSED_NATIVE_FILTER';

diff --git a/superset-frontend/src/dashboard/containers/DashboardPage.tsx b/superset-frontend/src/dashboard/containers/DashboardPage.tsx
@@ -158,7 +158,7 @@ const DashboardPage: FC = () => {
         isDashboardHydrated.current = true;
         if (isFeatureEnabled(FeatureFlag.DASHBOARD_NATIVE_FILTERS_SET)) {
           // only initialize filterset once
-          dispatch(getFilterSets());
+          dispatch(getFilterSets(id));
         }
       }
       dispatch(hydrateDashboard(dashboard, charts, filterboxMigrationState));