Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration failures at v0.13.0 #689

Closed
lintool opened this issue Jul 5, 2021 · 2 comments · Fixed by #703
Closed

Integration failures at v0.13.0 #689

lintool opened this issue Jul 5, 2021 · 2 comments · Fixed by #703

Comments

@lintool
Copy link
Member

lintool commented Jul 5, 2021

I'm getting integration failures on orca:

======================================================================
FAIL: test_dpr_curated_test_bf_bm25_hybrid_otf (test_dpr.TestSearchIntegration)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/store/scratch/jimmylin/pyserini/integrations/dense/test_dpr.py", line 239, in test_dpr_curated_test_bf_bm25_hybrid_otf
    self.assertAlmostEqual(score, 0.9006, places=4)
AssertionError: 0.3314 != 0.9006 within 4 places

======================================================================
FAIL: test_dpr_curated_test_bf_otf (test_dpr.TestSearchIntegration)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/store/scratch/jimmylin/pyserini/integrations/dense/test_dpr.py", line 215, in test_dpr_curated_test_bf_otf
    self.assertAlmostEqual(score, 0.8876, places=4)
AssertionError: 0.3285 != 0.8876 within 4 places

----------------------------------------------------------------------
@ArthurChen189 ArthurChen189 mentioned this issue Jul 6, 2021
Merged
@MXueguang
Copy link
Member

@lintool this should be closed by #692

@lintool
Copy link
Member Author

lintool commented Jul 9, 2021

Agreed.

@lintool lintool closed this as completed Jul 9, 2021
@lintool lintool mentioned this issue Jul 14, 2021
Merged
lintool added a commit that referenced this issue Jul 14, 2021
@lintool
DPR documentation fix (#703)
5d3f459 
Following #692 - which fixes #689 - changes need to be propagated to the documentation also.
MXueguang pushed a commit to MXueguang/pyserini that referenced this issue Nov 5, 2021
@lintool @MXueguang
DPR documentation fix (castorini#703)
2f19a58 
Following castorini#692 - which fixes castorini#689 - changes need to be propagated to the documentation also.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DPR documentation fix castorini/pyserini
2 participants
@lintool @MXueguang