-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add replication for MS MARCO passage experiment #25
Conversation
@ronakice do we really want separate lists for both models? How about: Results replicated by @MXueguang on 2020-05-22(commit |
@lintool in the case that we add more models (Which we probably will) I think this would be helpful? I figured that having people say (model 1 + model 2 + model 3) and occasionally just (model 2) is kinda messy? Unless we have separate docs for each. |
@MXueguang great job being the first to replicate our results! Do you happen to remember the amount of time it took on the P4 (not the preprocessing just curious about the 'inference' itself, I see monoT5 took ~27 minutes! |
@ronakice |
I think we should keep the models manageable per page? So, this being the "intro", no more models on this page. What do you think? |
That sounds like a good idea. |
But I think two models on the same page is reasonable... so keep the page content as is (but fold the two replication sections into one); if we want to add another model, we create a new page? |
Sounds like a plan. Yes, I was thinking that might be a good idea too since these are both similar enough pointwise estimators. Do we need to track GPUs this has worked on? We can assume that whoever replicates monoBERT can also replicate monoT5-base since it is quite a bit faster and ignore the (model 1 + model 2) part too. Something like Results replicated by @MXueguang on 2020-05-22 (commit 69de7db) (Tesla P4) |
👍 on this. We can always track back to PR for more details. |
@MXueguang please add the GPU, and @ronakice can merge. |
@MXueguang you can also remove the (monoBERT + monoT5) part. LGTM other than that! |
Awesome, great job @MXueguang |
Replication Status:
Success (No issues)
Environment:
OS: Ubuntu18.04 LTS
Python: 3.7.6
Pytorch: 1.5.0
GPU: Tesla P4
CUDA: 10.2
Replication Results:
monoBERT:
monoT5: