Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writer #17

Merged
merged 7 commits into from
May 4, 2020
Merged

Writer #17

merged 7 commits into from
May 4, 2020

Conversation

ronakice
Copy link
Member

@ronakice ronakice commented May 4, 2020

Add Writer to create output run files useful for evaluation and replication

@ronakice ronakice self-assigned this May 4, 2020
@ronakice ronakice requested a review from rodrigonogueira4 May 4, 2020 03:20
@ronakice ronakice removed their assignment May 4, 2020
Copy link
Member

@rodrigonogueira4 rodrigonogueira4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for implementing this! Just a minor comment

@ronakice ronakice merged commit ef31ca1 into master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants