Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tian #2118

Closed
wants to merge 4 commits into from
Closed

New tian #2118

wants to merge 4 commits into from

Conversation

Singularity-tian
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (820f581) 59.61% compared to head (3d37e98) 59.61%.

❗ Current head 3d37e98 differs from pull request most recent head b4042ea. Consider uploading reports for the commit b4042ea to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2118   +/-   ##
=========================================
  Coverage     59.61%   59.61%           
  Complexity     1215     1215           
=========================================
  Files           194      194           
  Lines         11377    11377           
  Branches       1488     1488           
=========================================
  Hits           6782     6782           
  Misses         4104     4104           
  Partials        491      491           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crystina-z
Copy link
Member

thanks! tho could we just add one line to the end, without changing the rest of the file? for example #2115.
Please also kindly note the environment: #2115 (comment).

@Singularity-tian
Copy link
Contributor Author

MacBook Pro Intel Chip, 16GB RAM, Monterey 12.6
Apache Maven 3.9.1, Java version: 20.0.1
Python 3.9.13
VSCode & Terminal
Problems: had to download the new version of JAVA and update JAVA_HOME

@lintool
Copy link
Member

lintool commented May 13, 2023

hrm... why are all the repro records change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants