Refactor MS MARCO v1 doc segmented uniCOIL regressions #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1854 +/- ##
=========================================
Coverage 57.51% 57.51%
Complexity 1055 1055
=========================================
Files 179 179
Lines 10188 10188
Branches 1407 1407
=========================================
Hits 5860 5860
Misses 3836 3836
Partials 492 492 Continue to review full report at Codecov.
|
|
@MXueguang all tests pass on my end. Please take a look and we'll merge. |
MXueguang
approved these changes
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1853
@MXueguang - I'm still running regressions, but I'll let you start taking a look first.