-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prioritize pmc json #1101
Prioritize pmc json #1101
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1101 +/- ##
============================================
- Coverage 46.61% 46.55% -0.07%
Complexity 680 680
============================================
Files 143 143
Lines 8233 8242 +9
Branches 1168 1172 +4
============================================
- Hits 3838 3837 -1
- Misses 4056 4065 +9
- Partials 339 340 +1
Continue to review full report at Codecov.
|
hi @lukuang just for completeness, can we keep the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! LGTM, ran it locally and it works
Waiting for @lukuang to revert the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for @lukuang to revert the
pdf_json
copy and then I'll merge.
Done. Please go ahead and ship.
Thanks @lukuang ! |
According to the FAQs of the CORD-19 data set, we should use pmc json whenever possible, which were made available in recent releases.