List api support #272
Merged
List api support #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymond
commented
Oct 29, 2024
andymond
commented
Oct 29, 2024
andymond
commented
Oct 29, 2024
opti
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Hi @andymond! Thank you for the time and effort you've put into this contribution. I really appreciate that.
I left a few minor comments throughout the code, but it overall looks good to me.
Let's not introduce the "allowed" validator concept. It's better to keep it open for further API development.
opti
reviewed
Oct 30, 2024
andymond
force-pushed
the
list-api-support
branch
from
2d1f712 to
b27bba9
Compare
opti
reviewed
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft