impersonate - raise error when non success response is returned #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartes
force-pushed
the
impersonation_error
branch
from
589d826 to
375ca61
Compare
nijikon
force-pushed
the
impersonation_error
branch
from
375ca61 to
4d9262a
Compare
mensfeld
reviewed
Apr 17, 2018
lib/castle/client.rb
Outdated
| @@ -81,7 +81,9 @@ def impersonate(options = {}) | |||
| options = Castle::Utils.deep_symbolize_keys(options || {}) | |||
| add_timestamp_if_necessary(options) | |||
| command = Castle::Commands::Impersonate.new(@context).build(options) | |||
| @api.request(command) | |||
| @api.request(command).tap do |response| | |||
| raise Castle::ApiError, 'Impersonate request failed' unless response[:success] | |||
There was a problem hiding this comment.
this should be a custom error.
There was a problem hiding this comment.
@mensfeld - corrected
nijikon
force-pushed
the
impersonation_error
branch
from
d376e74 to
6b0007a
Compare
mensfeld
reviewed
Apr 18, 2018
| @@ -81,7 +81,9 @@ def impersonate(options = {}) | |||
| options = Castle::Utils.deep_symbolize_keys(options || {}) | |||
| add_timestamp_if_necessary(options) | |||
| command = Castle::Commands::Impersonate.new(@context).build(options) | |||
| @api.request(command) | |||
| @api.request(command).tap do |response| | |||
| raise Castle::ImpersonationFailed unless response[:success] | |||
There was a problem hiding this comment.
you could provide a context or some details as a raise argument, it will make debuggng easier.
mensfeld
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.