Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit CI/CD push trigger to dev branch only. #1291

Merged
1 commit merged into from
Oct 17, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 26, 2023

What does this PR address?

  • Reduces duplicated CI/CD checks.
  • Prevents pipelines from running on arbitrary branches.

Closes #1290.

@ghost ghost requested a review from bradjohnl September 26, 2023 13:18
@ghost ghost requested a review from ACStone-MTS as a code owner September 26, 2023 13:18
@ghost ghost self-assigned this Sep 26, 2023
@github-actions
Copy link

@bradjohnl
Copy link
Contributor

@andrzej-casper While it's good to remove duplicated CI runs, running the CI on every branch had the advantage of giving constant feedback to developers and contributors.

If @adam and @ipopescu are fine with having feedback on builds only on PRs and after a successful merge, then I am fine with this change.

If you'd still like to have the continuous feedback on every push to every branch, then we have to find some other way to prevent duplicate builds I guess

@ipopescu
Copy link
Collaborator

@andrzej-casper @bradjohnl @ACStoneCL, I think having the CI/CD checks for open PRs, and after a PR merge to the dev branch, is sufficient. Also, it is good to run the docs locally when we're creating documentation. I forget the rationale behind "continuous feedback on every push to every branch". Perhaps it was nice to have during the docs restructuring, when we had 10+ branches in progress at one time, but if it is causing side effects now, we can reduce the checks.

@ghost
Copy link
Author

ghost commented Oct 16, 2023

@bradjohnl, please note that for any changes requiring CI/CD, contributors can use PR drafts. I just did that with #1305 to run preview deployment for some stale branch.

@ghost ghost merged commit 6b3d9b8 into dev Oct 17, 2023
8 checks passed
@ghost ghost deleted the 1290-cicd-duplicated-checks-for-pull-requests branch October 17, 2023 07:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI/CD] Duplicated checks for pull requests
2 participants