Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Tag Manager configuration #1068

Merged
8 commits merged into from
Apr 14, 2023
Merged

Google Tag Manager configuration #1068

8 commits merged into from
Apr 14, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 13, 2023

What does this PR fix?

Changes to utilize Google Analytics:

  • Remove GOOGLE_ANALYTICS_TRACKING_ID - not used, also see deprecation note in https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-google-analytics.
  • Rename GOOGLE_ANALYTICS_ANONYMIZE_IP to GOOGLE_TAG_ANONYMIZE_IP - for consistency with GOOGLE_TAG_TRACKING_ID.
  • Rename config/analytics.config.js to config/gtag.config.js.
  • Enable gtag in Docusaurus (conditionally).
  • Switch to variables instead of secrets - google tags are not private, so there is no reason to hide them.
  • IP anonymization is enabled by default - as it was previously - but now it can be properly disabled, by setting "false" in repository variables.

Additional context

Related task: #1067. Before merging this, repository secrets/variables must be updated accordingly.

Checklist

  • Docs are successfully building - yarn install && yarn run build.
  • All technical procedures have been tested.

@ghost ghost requested a review from bradjohnl April 13, 2023 19:22
@ghost ghost requested a review from ACStone-MTS as a code owner April 13, 2023 19:22
@ghost
Copy link
Author

ghost commented Apr 14, 2023

Repository variables are updated accordingly:

image

@ghost ghost merged commit 64936d9 into dev Apr 14, 2023
@ghost ghost deleted the 1067-configure-google-analytics branch April 14, 2023 09:02
@ghost ghost mentioned this pull request Apr 14, 2023
2 tasks
ghost pushed a commit that referenced this pull request Aug 21, 2023
…alytics

Google Tag Manager configuration
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant