Address dev branch toolchain issues.
#149
Conversation
…s casper-node Signed-off-by: Zach Showalter <[email protected]>
Signed-off-by: Zach Showalter <[email protected]>
Signed-off-by: Zach Showalter <[email protected]>
…hort git commit hash to the clients version string Signed-off-by: Zach Showalter <[email protected]>
…ets the `GIT_SHA_SHORT` env var during compile time so the client may use `env!` macros to populate the version string with a short git commit hash. Signed-off-by: Zach Showalter <[email protected]>
…. (Using only one colon vs two for `cargo:rustc-env`) Signed-off-by: Zach Showalter <[email protected]>
Signed-off-by: Zach Showalter <[email protected]>
Cargo.toml
Outdated
| @@ -51,7 +51,6 @@ uint = "0.9.5" | |||
| tempfile = "3.8.1" | |||
|
|
|||
| [build-dependencies] | |||
There was a problem hiding this comment.
I guess you can remove [build-dependencies] now.
Are you really really sure you have to fix clap ?
There was a problem hiding this comment.
At least I observed issues where clap_lex (and likely other clap packages) specified a minimum Rust version (the is already on 1.74).
You can see that clap 4.4.18 fixes it at 1.70, whereas 4.5.0 already requires 1.74.
We could consider something less strict like <4.5.0 instead of =... though?
There was a problem hiding this comment.
I agree that the more liberal we can be with the versioning the better. I don't know what the SOP is for moving the toolchain version forward on the node. That is, when should we be moving the versioning forward vs leaving it the same.
Seeing as we currently don't use any of these cutting edge clap features, I don't see any reason to increment the toolchain version as we don't have a need to do so on the client.
There was a problem hiding this comment.
As it turns out the best I can do on this is pinning clap to ~4.4 and putting clap_complete at <4.5.0.
Setting clap at <4.5, for some esoteric reason, results in issues with clap_lex specifying Rust version 1.74
Signed-off-by: Zach Showalter <[email protected]>
|
Looks good, although consider the slightly more liberal version fix. @zacshowa I think getting rid of |
I agree, It's functionality could easily be replaced with standard library functions and calls to git. This would reduce the future risk of transitive dependency security issues at the cost of a small effort. |
Signed-off-by: Zach Showalter <[email protected]>
Signed-off-by: Zach Showalter <[email protected]>
|
FYI, |
Signed-off-by: Zach Showalter <[email protected]>
Signed-off-by: Zach Showalter <[email protected]>
Signed-off-by: Zach Showalter <[email protected]>
…tem#175 Part of casper-ecosystem#144 Enable CI CD check on feat-track-2.0
Changes in this PR
This PR adds a
rust-toolchain.rsto the repo, pinning the rust toolchain to the samedevin casper-node.Additionally, this PR removes a dependency on
vergenin thebuild.rsbuild script.vergenwith standard library functions to ask Cargo to populate an env var during the build lifecycle that the client reads while constructing its version string.