Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added keyremap4macbook #7813

Closed
wants to merge 1 commit into from
Closed

added keyremap4macbook #7813

wants to merge 1 commit into from

Conversation

vitorgalvao
Copy link
Member

Refs Homebrew/homebrew-cask-versions#586

keyremap4macbook-mountainlion is a weird one. It was renamed to karabiner with the mavericks version. This PR proposes we deleted it from caskroom/versions and add it here as a separate cask with a depends_on :mac_os that only goes into mountain_lion. I’m not fully convinced, though. As I write this, I wonder if we shouldn’t simply replace it in caskroom/versions.

It wasn’t included into Karabiner because a lot of things differ between them, and we’d essentially be managing two apps in the same cask.

Pinging @rolandwalker and @ndr-qef.

@rolandwalker
Copy link
Contributor

Agreed, we should just merge keyremap4macbook* and keep them in the versions repo. Multiple app names coexisting in the same Cask is too confusing for end-users.

Tangentially, this is a case where (in the main repo) I would put both

name "Karabiner"
name "Keyremap4Macbook"

to make it searchable under the old name.

@vitorgalvao
Copy link
Member Author

Sounds good, I’ve submitted it on caskroom/versions. Are you in agreement, @ndr-qef? If you are, feel free to outright close this PR.

@tapeinosyne
Copy link
Contributor

Agreed. keyremap4macbook is largely an unmaintained legacy version; furthermore, considering the high adoption rate of OS X releases, keeping it in caskroom/versions should inconvenience very few users.

@tapeinosyne tapeinosyne closed this Dec 8, 2014
@vitorgalvao vitorgalvao deleted the keyremap4macbook branch December 18, 2014 16:19
@adidalal adidalal removed the awaiting maintainer feedback Issue needs response from a maintainer. label Jan 3, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants