be explicit: no fallthrough for apps from titantium.free.fr #7799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
changed the title
|
Sounds reasonable. All for it. |
|
Wouldn't it be prudent to notify the user that no installation is available? Some kind of error message? |
|
@jawshooah yes, that is guaranteed two ways: The I will revise the comment to say "define nothing" instead of "do nothing" to make that a little more clear. |
|
Right, forgot about the |
each version is specific to an OS X release
each version is specific to an OS X release
each version is specific to an OS X release
rolandwalker
force-pushed
the
titanium_casks
branch
from
5909e56 to
d1803c4
Compare
|
I sincerely appreciate the review, especially as I am making lots of errors today. Updated the comment. |
rolandwalker
added a commit
that referenced
this pull request
Dec 5, 2014
be explicit: no fallthrough for apps from titantium.free.fr
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each version is specific to an OS X release.
This is already more or less in effect due to
depends_on :macos, but theelseclause contradicted that meaning. This syncs the conditional and thedepends_on.