Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move certificate parameters to a dedicated struct #54

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

yoavamit
Copy link
Collaborator

When generating a certificate or a certificate signing request, instead of getting the certificate subject information directly from environment variables, they'll be passed to the GenerateCertificate function in a dedicated struct.
The environment variables will still be used by the pivit CLI executable to populate the CertificateParameters struct when calling pivit --generate.

When generating a certificate or a certificate signing request, instead of getting the certificate subject information directly from environment variables, they'll be passed to the `GenerateCertificate` function in a dedicated struct.
The environment variables will still be used by the pivit CLI executable to populate the `CertificateParameters` struct when calling `pivit --generate`.
@yoavamit yoavamit requested a review from linuxwolf August 15, 2024 14:50
Copy link
Collaborator

@linuxwolf linuxwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔑

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.73%. Comparing base (51d77d0) to head (c616c6a).
Report is 6 commits behind head on main.

Files Patch % Lines
pkg/pivit/generate.go 89.28% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   63.22%   62.73%   -0.50%     
==========================================
  Files          10       10              
  Lines         756      754       -2     
==========================================
- Hits          478      473       -5     
- Misses        212      214       +2     
- Partials       66       67       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoavamit yoavamit merged commit 3b5a1af into main Aug 16, 2024
7 of 8 checks passed
@yoavamit yoavamit deleted the move-certificate-params-to-struct branch August 16, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants