fix: check size before calling single(). Declare IllegalArgumentException.

core/src/main/kotlin/cash/grammar/kotlindsl/utils/DependencyExtractor.kt

@@ -326,9 +326,14 @@ public class DependencyExtractor(
   }
 
   private fun PostfixUnaryExpressionContext.isDependencyDeclaration(): DeclarationDetectionResult {
+    // Something strange
+    if (postfixUnarySuffix().size != 1) return DeclarationDetectionResult.STATEMENT
+
     // This is everything after the configuration, including optionally a trailing lambda
     val rawDependency = postfixUnarySuffix().single().callSuffix()
-    val args = rawDependency.valueArguments().valueArgument()
+    // Probably not actually a dependencies block
+    val valueArguments = rawDependency.valueArguments() ?: return DeclarationDetectionResult.STATEMENT
+    val args = valueArguments.valueArgument()
 
     // If there are more than one argument, it's a function call, not a dependency declaration
     return if (args.size <= 1) {

recipes/dependencies/src/main/kotlin/cash/recipes/dependencies/DependenciesSimplifier.kt

@@ -4,7 +4,6 @@ import cash.grammar.kotlindsl.model.DependencyDeclaration
 import cash.grammar.kotlindsl.parse.KotlinParseException
 import cash.grammar.kotlindsl.parse.Parser
 import cash.grammar.kotlindsl.parse.Rewriter
-import cash.grammar.kotlindsl.utils.Blocks.isBuildscript
 import cash.grammar.kotlindsl.utils.Blocks.isDependencies
 import cash.grammar.kotlindsl.utils.CollectingErrorListener
 import cash.grammar.kotlindsl.utils.Context.leafRule
@@ -14,6 +13,7 @@ import cash.grammar.kotlindsl.utils.Whitespace.trimGently
 import cash.grammar.utils.ifNotEmpty
 import com.squareup.cash.grammar.KotlinParser.NamedBlockContext
 import com.squareup.cash.grammar.KotlinParser.PostfixUnaryExpressionContext
+import com.squareup.cash.grammar.KotlinParser.ScriptContext
 import com.squareup.cash.grammar.KotlinParser.StatementContext
 import com.squareup.cash.grammar.KotlinParserBaseListener
 import org.antlr.v4.runtime.CharStream
@@ -34,7 +34,6 @@ public class DependenciesSimplifier private constructor(
   private val dependencyExtractor = DependencyExtractor(input, tokens, indent)
 
   private var changes = false
-  private var isInBuildscriptBlock = false
 
   public fun isChanged(): Boolean = changes
 
@@ -49,24 +48,24 @@ public class DependenciesSimplifier private constructor(
 
   override fun enterNamedBlock(ctx: NamedBlockContext) {
     dependencyExtractor.onEnterBlock()
-
-    if (ctx.isBuildscript) {
-      isInBuildscriptBlock = true
-    }
   }
 
   override fun exitNamedBlock(ctx: NamedBlockContext) {
-    if (ctx.isDependencies && !isInBuildscriptBlock) {
+    if (isRealDependenciesBlock(ctx)) {
       onExitDependenciesBlock(ctx)
     }
 
-    if (ctx.isBuildscript) {
-      isInBuildscriptBlock = false
-    }
-
     dependencyExtractor.onExitBlock()
   }
 
+  private fun isRealDependenciesBlock(ctx: NamedBlockContext): Boolean {
+    // parent is StatementContext. Parent of that should be ScriptContext
+    // In contrast, with tasks.shadowJar { dependencies { ... } }, the parent.parent is StatementsContext
+    if (ctx.parent.parent !is ScriptContext) return false
+
+    return ctx.isDependencies
+  }
+
   private fun onExitDependenciesBlock(ctx: NamedBlockContext) {
     val container = dependencyExtractor.collectDependencies(ctx)
     container.getDependencyDeclarationsWithContext()
@@ -119,8 +118,9 @@ public class DependenciesSimplifier private constructor(
      * Returns a [DependenciesSimplifier], which eagerly parses [buildScript].
      *
      * @throws IllegalStateException if [DependencyExtractor] sees an expression it doesn't understand.
+     * @throws IllegalArgumentException if [DependencyExtractor] sees an expression it doesn't understand.
      */
-    @Throws(IllegalStateException::class)
+    @Throws(IllegalStateException::class, IllegalArgumentException::class)
     public fun of(buildScript: Path): DependenciesSimplifier {
       return of(Parser.readOnlyInputStream(buildScript))
     }
@@ -129,8 +129,9 @@ public class DependenciesSimplifier private constructor(
      * Returns a [DependenciesSimplifier], which eagerly parses [buildScript].
      *
      * @throws IllegalStateException if [DependencyExtractor] sees an expression it doesn't understand.
+     * @throws IllegalArgumentException if [DependencyExtractor] sees an expression it doesn't understand.
      */
-    @Throws(IllegalStateException::class)
+    @Throws(IllegalStateException::class, IllegalArgumentException::class)
     public fun of(buildScript: String): DependenciesSimplifier {
       return of(buildScript.byteInputStream())
     }
@@ -139,8 +140,9 @@ public class DependenciesSimplifier private constructor(
      * Returns a [DependenciesSimplifier], which eagerly parses [buildScript].
      *
      * @throws IllegalStateException if [DependencyExtractor] sees an expression it doesn't understand.
+     * @throws IllegalArgumentException if [DependencyExtractor] sees an expression it doesn't understand.
      */
-    @Throws(IllegalStateException::class)
+    @Throws(IllegalStateException::class, IllegalArgumentException::class)
     private fun of(buildScript: InputStream): DependenciesSimplifier {
       val errorListener = CollectingErrorListener()
 

recipes/dependencies/src/test/kotlin/cash/recipes/dependencies/DependenciesSimplifierTest.kt

@@ -38,4 +38,32 @@ internal class DependenciesSimplifierTest {
       """.trimIndent()
     )
   }
+
+  @Test fun `can handle user weirdness`() {
+    // Expect parsing not to throw exception
+    DependenciesSimplifier.of(
+      """
+        dependencies {
+          tasks.withType<Foo>().configureEach {
+            doThing(listOf("--a", "b"))
+          }
+        }
+      """.trimIndent()
+    )
+  }
+
+  @Test fun `handles dependencies blocks that aren't actually dependencies blocks`() {
+    // Expect parsing not to throw exception
+    DependenciesSimplifier.of(
+      """
+        tasks.shadowJar {
+          dependencies {
+            exclude { dep ->
+              dep.name != "foo"
+            }
+          }
+        }
+      """.trimIndent()
+    )
+  }
 }