Fix powershell shebang, closes #825

src/platform.rs

@@ -18,10 +18,6 @@ impl PlatformInterface for Platform {
     Ok(cmd)
   }
 
-  fn get_recipe_file_ext(command: &str) -> String {
-      return String::new();
-  }
-
   fn set_execute_permission(path: &Path) -> Result<(), io::Error> {
     use std::os::unix::fs::PermissionsExt;
 
@@ -85,14 +81,6 @@ impl PlatformInterface for Platform {
     Ok(cmd)
   }
 
-  fn get_recipe_file_ext(command: &str) -> String {
-      if command.ends_with("powershell.exe") {
-          format!("{}", ".ps1")
-      } else {
-        String::new()
-      }
-  }
-
   fn set_execute_permission(_path: &Path) -> Result<(), io::Error> {
     // it is not necessary to set an execute permission on a script on windows, so
     // this is a nop

src/platform_interface.rs

@@ -11,7 +11,13 @@ pub(crate) trait PlatformInterface {
   ) -> Result<Command, OutputError>;
 
   /// Get generate file ext
-  fn get_recipe_file_ext(command: &str) -> String;
+  fn get_script_file_ext(command: &str) -> &str {
+      if command.ends_with("powershell") {
+          ".ps1"
+      } else {
+          ""
+      }
+  }
 
   /// Set the execute permission on the file pointed to by `path`
   fn set_execute_permission(path: &Path) -> Result<(), io::Error>;

src/recipe.rs

@@ -129,8 +129,8 @@ impl<'src, D> Recipe<'src, D> {
           io_error: error,
         })?;
       let mut path = tmp.path().to_path_buf();
-      let ext = Platform::get_recipe_file_ext(interpreter);
-      path.push(format!("{}{}", self.name(), ext));
+      let ext_name = Platform::get_script_file_ext(interpreter);
+      path.push(format!("{}{}", self.name(), ext_name));
       {
         let mut f = fs::File::create(&path).map_err(|error| RuntimeError::TmpdirIoError {
           recipe:   self.name(),

tests/lib.rs

@@ -22,6 +22,7 @@ mod positional_arguments;
 mod quiet;
 mod readme;
 mod search;
+mod shebang;
 mod shell;
 mod string;
 mod working_directory;

tests/shebang.rs

@@ -0,0 +1,31 @@
+use std::{process::Command, str};
+
+use executable_path::executable_path;
+
+use test_utilities::{assert_stdout, tmptree};
+
+const JUSTFILE_POWERSHELL: &str = r#"
+set shell := ["powershell.exe", "-c"]
+
+default:
+    #!powershell
+    Write-Host Hello-World
+"#;
+
+/// Test powershell shebang
+#[test]
+#[cfg_attr(unix, ignore)]
+fn powershell() {
+  let tmp = tmptree! {
+    justfile: JUSTFILE_POWERSHELL,
+  };
+
+  let output = Command::new(executable_path("just"))
+    .current_dir(tmp.path())
+    .output()
+    .unwrap();
+
+  let stdout = "Hello-World\n";
+
+  assert_stdout(&output, stdout);
+}