-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add just_executable() function #775
Conversation
2581c64
to
ebe4194
Compare
For the windows build, I'm not sure how to fix this:
Do I need to change the value returned by the function to make still new to rust |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you for the PR! I made comments regarding style and formatting, but otherwise this looks great.
I changed the PR following your comments! Edit: windows test is not better 😕 |
Either way is fine with me!
Hmmm, try this:
The behavior of echo with respect to backslashes can be inconsistent. Printf is consistent across platforms, and does not interpret escape sequences in arguments after the first. |
I got some weird messages with that printf line, and I had a hard time finding the reason ^^ With errors ranging from The solution was to not use a Let's see how Windows work now |
Nice, merged! Thank you for the idea, and the implementation. I just released v0.8.6 that contains this change. |
Closes #774
I did not add tests because I couldn't find tests for the other functions, but if you need them I can add those.EDIT: nevermind, I've found them, will try to make a test