Forbid duplicated non-repeatable attributes #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forbid duplicated non-repeatable attributes in the parser. Duplicate attributes with different values were previously accepted by the compiler, often to ill effect, like multiple
confirmattributes being allowed on a recipe, but only one being respected.This fixes that by disallowing all duplicate non-repeatable attributes, regardless of whether they have different arguments or not. The only repeatable attribute is the
[group]attribute, since recipes can be in multiple groups.This is a backwards compatibility break, but it is most definitely a bug, and backwards compatibility breaking bug fixes are allowed.