-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress recipe not found error code #2460
Conversation
The name
|
Fair enough, I will make the according naming changes, are there any changes that should be made, regarding either the implementation or the tests? |
Verbosity levels should only affect what's printed and not what error codes are returned, so I think this should be a flag. I'm not entirely satisfied with Other ideas:
|
I myself am a fan of either |
Let's go with |
5d9f9b6
to
4597aad
Compare
Changed everything to match the feedback, if there is anything else you would like me to change, please let me know! Perhaps the description could be more specific than |
I tweaked this a bit. The main change was to move the check for unknown recipes into |
Closes #2275. It adds a new verbosity version which is used to convert the error code of an
UnknownRecipe
to 0, due to it making an early return it will also suppress any error messages. This behaviour is the same as the onenpm --if-present
has as it was referenced by the issue author.I choose to add another verbosity variant due to not wanting to add further fields in
Config
. I thought it fits the verbosity config since it affects the output of the program.