Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight refactors in subcommand and search modules #2335

Merged
merged 7 commits into from
Aug 31, 2024

Conversation

neunenak
Copy link
Contributor

  • adds some documentation comments for various methods on Search
  • passes Compilation into several Subcommand handler methods to reduce cluttering up the outer scope of Subcommand::execute
  • makes some code slightly more concise in a few areas

@casey casey force-pushed the subcommand-evaluation-refactor branch from 5b657b4 to 2d8be1d Compare August 31, 2024 19:25
@casey
Copy link
Owner

casey commented Aug 31, 2024

I wasn't a huge fan of the refactor to init to use variables to store the justfile and working_directory, but otherwise looks good, made some tweaks to the docs, and passing in a Compilation is definitely an improvement.

@casey casey enabled auto-merge (squash) August 31, 2024 19:26
@casey casey merged commit f222b02 into casey:master Aug 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants