Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python package wrapper (pyproject.toml) and wheel action #2312

Closed
wants to merge 1 commit into from

Conversation

rachtsingh
Copy link

Fixes #2311

Should hopefully not be a big maintenance burden, but will make it easier for me to recommend just as the Python make replacement.

To do (by maintainer):

  • decide on package name (I picked justcli since just was taken on PyPI, but no preference)
  • create a PyPI account and set the PYPI_API_TOKEN in Github to allow uploads

While looking at PyPI for a good name I found this package that wraps just: pybin, but it looks like it is releasing a (slightly) older version of just, i.e. 1.26.0.

@casey
Copy link
Owner

casey commented Aug 14, 2024

It's a bit convoluted, but in workflows/ci/release, there's a test for whether or not the tag matches [[:digit:]]+[.][[:digit:]]+[.][[:digit:]], i.e., whether or not it's a version tag x.y.z or some other tag. If it's not a version tag, the release job runs, but it doesn't publish the built artifacts. Can you add this to the maturin job? Otherwise, there's no way to run the job, for debugging, without also attempting to upload those wheels. (Unless there's some other way to do this with the existing workflow.)

@dalito
Copy link

dalito commented Aug 15, 2024

This is interesting. It would also make just installable via pipx, or not? (and pipx is by default available in gh-actions)

@casey
Copy link
Owner

casey commented Aug 16, 2024

I'm not sure if it would allow you to install them directly. You would need the wheels, which would only exist after an actions run, so they would be hard to grab.

@casey
Copy link
Owner

casey commented Sep 14, 2024

See comments in #2361, but I'm leaning towards not adding this. I fear it will get out of date or the build will break, and I'm honestly pretty unlikely to test it, so I would suggest maintaining this out-of-tree, and I can link to it in the readme. For the package name, I would suggest rust-just, but justcli is fine too.

@casey casey closed this Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Installation via pip?
3 participants