-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make install
an optional dependency and add 32-bit arm targets
#2214
Conversation
install
an optional dependency and add 32-bit arm targets
It is tested on a Zynq-7000 which has this output for
This device does not have |
Now also tested on Raspberry PI 0 which has this Linux hostname 6.1.21+ #1642 Mon Apr 3 17:19:14 BST 2023 armv6l GNU/Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. I think we should just always use cp
and chmod
on unix, since there's no particularly advantage to using install
. See comments for more details.
e13007d
to
dad894b
Compare
Requested changes implemented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
Resolves #1284
Believe it or not, some Linux embedded device will not have
install
installed. This is not uncommon when they have a custom distribution build with Buildroot or Yocto, such devices typically havecp
andchmod
though, so wheninstall
is not available, there's now a fall back to cp and chmod.Then I added 32-bit arm targets, that includes old Raspberry Pi models but also various embedded linux devices such as Xilinx Zynq family.