Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make install an optional dependency and add 32-bit arm targets #2214

Merged
merged 8 commits into from
Jul 1, 2024

Conversation

CramBL
Copy link
Contributor

@CramBL CramBL commented Jul 1, 2024

Resolves #1284

Believe it or not, some Linux embedded device will not have install installed. This is not uncommon when they have a custom distribution build with Buildroot or Yocto, such devices typically have cp and chmod though, so when install is not available, there's now a fall back to cp and chmod.

Then I added 32-bit arm targets, that includes old Raspberry Pi models but also various embedded linux devices such as Xilinx Zynq family.

@CramBL CramBL changed the title add 32-bit arm targets Make install an optional dependency and add 32-bit arm targets Jul 1, 2024
@CramBL
Copy link
Contributor Author

CramBL commented Jul 1, 2024

It is tested on a Zynq-7000 which has this output for uname -a:

Linux hostname 5.15.19-xilinx-v2022.1 #1 SMP PREEMPT Wed Aug 24 06:33:16 UTC 2022 armv7l GNU/Linux

This device does not have install.

@CramBL
Copy link
Contributor Author

CramBL commented Jul 1, 2024

Now also tested on Raspberry PI 0 which has this uname -a output

Linux hostname 6.1.21+ #1642 Mon Apr  3 17:19:14 BST 2023 armv6l GNU/Linux

Copy link
Owner

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. I think we should just always use cp and chmod on unix, since there's no particularly advantage to using install. See comments for more details.

www/install.sh Outdated Show resolved Hide resolved
www/install.sh Outdated Show resolved Hide resolved
www/install.sh Outdated Show resolved Hide resolved
www/install.sh Outdated Show resolved Hide resolved
@CramBL CramBL force-pushed the improve-install-robustness branch from e13007d to dad894b Compare July 1, 2024 17:41
@CramBL
Copy link
Contributor Author

CramBL commented Jul 1, 2024

Requested changes implemented

Copy link
Owner

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@casey casey enabled auto-merge (squash) July 1, 2024 18:34
@casey casey merged commit 5695384 into casey:master Jul 1, 2024
5 checks passed
@CramBL CramBL deleted the improve-install-robustness branch July 1, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install script does not work on Raspberry Pi Zero
2 participants