Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: add link to more examples #2198

Merged
merged 3 commits into from
Jun 27, 2024
Merged

readme: add link to more examples #2198

merged 3 commits into from
Jun 27, 2024

Conversation

bukowa
Copy link
Contributor

@bukowa bukowa commented Jun 27, 2024

No description provided.

@bukowa bukowa changed the title docs: add link to more examples readme: add link to more examples Jun 27, 2024
Copy link
Owner

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! See review for a suggested change.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Casey Rodarmor <[email protected]>
@casey
Copy link
Owner

casey commented Jun 27, 2024

This needs to be rebased on latest master.

@casey casey enabled auto-merge (squash) June 27, 2024 20:39
@bukowa
Copy link
Contributor Author

bukowa commented Jun 27, 2024

This needs to be rebased on latest master.

Not sure if you receive notification on my pushes?
Done.

@casey
Copy link
Owner

casey commented Jun 27, 2024

I sometimes get notifications when someone pushes to a branch, but I don't check the PR when that happens, since a push doesn't necessarily mean the PR is ready for review.

@casey
Copy link
Owner

casey commented Jun 27, 2024

Looks good to me!

@casey casey merged commit 929fd69 into casey:master Jun 27, 2024
5 checks passed
@bukowa bukowa deleted the examplesread branch June 27, 2024 22:57
@bukowa
Copy link
Contributor Author

bukowa commented Jun 27, 2024

Looks good to me!

Damn somehow broken :D

@casey
Copy link
Owner

casey commented Jun 27, 2024

Whoops, that's my fault. Fixed in #2203.

Spatenheinz pushed a commit to Spatenheinz/just that referenced this pull request Jun 28, 2024
Spatenheinz pushed a commit to Spatenheinz/just that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants