Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case-conversion functions (#1376) #1383

Merged
merged 9 commits into from
Oct 27, 2022

Conversation

gVirtu
Copy link
Contributor

@gVirtu gVirtu commented Oct 27, 2022

As per #1376, adds a thin wrapper to heck's case conversion utilities, along with straightforward tests to each one.

Hopefully it ends up being useful! :)

Copy link
Owner

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! To make it super obvious what the different functions do, let's use the destination case in the description of each function.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Owner

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and committed the suggested changes to the readme.

@casey casey enabled auto-merge (squash) October 27, 2022 03:30
@casey casey disabled auto-merge October 27, 2022 03:30
@casey casey enabled auto-merge (squash) October 27, 2022 03:30
@casey casey merged commit be11a26 into casey:master Oct 27, 2022
@casey
Copy link
Owner

casey commented Oct 27, 2022

FYI, since just is a binary crate, changes to Cargo.lock should be committed.

Merged, thank you for the PR! I'm sure people will wind up using this. Case conversion is common enough, and case conversion in the shell is pretty miserable.

@gVirtu
Copy link
Contributor Author

gVirtu commented Oct 27, 2022

@casey thank you!! I'd signed off for the day so appreciate the help.

I wasn't sure about the Cargo.lock change (newbie to the rust ecosystem 😃 ) since heck ended up being the only one with a version number so I suspected it was a Rust version mismatch on my end.

Thank you once more and congratulations on maintaining the project, it's organized very nicely, easy to set up and well tested. I'm starring it myself!

@casey
Copy link
Owner

casey commented Oct 27, 2022

You bet, and thank you for the kind words! Contributions like yours make it fun and motivating to work on in the long term, so thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants