More pr comments

casey · Nov 1, 2024 · fe755a7 · fe755a7
1 parent c430df3
commit fe755a7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/src/attribute.rs b/src/attribute.rs
@@ -1,3 +1,5 @@
+use std::collections::{self};
+
 use super::*;
 
 #[derive(
@@ -136,14 +138,14 @@ impl<'src> Display for Attribute<'src> {
 #[derive(Default, Debug, Clone, PartialEq, Serialize)]
 pub(crate) struct AttributeSet<'src>(BTreeSet<Attribute<'src>>);
 
-impl<'src> IntoIterator for &AttributeSet<'src> {
-    type Item = &'src Attribute<'src>;
+impl<'src, 'a> IntoIterator for &'a AttributeSet<'src> {
+  type Item = &'a Attribute<'src>;
 
-    type IntoIter;
+  type IntoIter = collections::btree_set::Iter<'a, Attribute<'src>>;
 
-    fn into_iter(self) -> Self::IntoIter {
-        todo!()
-    }
+  fn into_iter(self) -> Self::IntoIter {
+    self.0.iter()
+  }
 }
 
 impl<'src> AttributeSet<'src> {

diff --git a/src/recipe.rs b/src/recipe.rs
@@ -483,7 +483,7 @@ impl<'src, D: Display> ColorDisplay for Recipe<'src, D> {
       writeln!(f, "# {doc}")?;
     }
 
-    for attribute in self.attributes.iter() {
+    for attribute in &self.attributes {
       writeln!(f, "[{attribute}]")?;
     }