Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Release Process #56

Closed
wants to merge 2 commits into from
Closed

Update Release Process #56

wants to merge 2 commits into from

Conversation

ajnelson-nist pushed a commit to casework/CASE-Implementation-PROV-O that referenced this pull request Jun 8, 2022
This patch was originally authored for case-utils PR 56.

It is being prototyped for the initial PyPI upload of this repository.

References:
* casework/CASE-Utilities-Python#56

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist
Copy link
Member

@kchason - we currently hard-code a Python versions matrix that only runs 3.7 and 3.10. Does this mean we will make 2 wheels, or 4 (the other two being 3.8 and 3.9 somehow automagically picked up)?

@kchason
Copy link
Member Author

kchason commented Jun 8, 2022

@kchason - we currently hard-code a Python versions matrix that only runs 3.7 and 3.10. Does this mean we will make 2 wheels, or 4 (the other two being 3.8 and 3.9 somehow automagically picked up)?

It'll make two wheels. We can entirely separate the workflows to have just one "build" job.

@ajnelson-nist
Copy link
Member

@kchason - we currently hard-code a Python versions matrix that only runs 3.7 and 3.10. Does this mean we will make 2 wheels, or 4 (the other two being 3.8 and 3.9 somehow automagically picked up)?

It'll make two wheels. We can entirely separate the workflows to have just one "build" job.

Maybe this is worth specifying as a need for this PR:
Even if we only do tests in 3.7 and 3.10 to save on CI time, whatever gets uploaded to PyPI should be install-able with pip install case-utils when the client's Python version is 3.8.

The upload artifact from our first try is case_utils-0.5.0-py3-none-any.whl. That was due to a manual run.

Since a none-any.whl file goes up at least once, the requirement I just noted above is satisfied. It'd be wasteful to upload a none-any.whl file twice. Let's see what happens with the CASE PROV-O try, and then consider making the build job work only once if we need to.

@ajnelson-nist
Copy link
Member

Well, my original plan of testing with the PROV-O mapping ended up not working out timing-wise. Let's try this in the case-utils repository instead for the CASE 0.7.0 release.

I'd like to merge this, but it's being pointed at main. @kchason , can you please re-point it at develop?

@kchason kchason closed this Jun 17, 2022
@ajnelson-nist ajnelson-nist deleted the update-release-process branch June 17, 2022 12:33
@ajnelson-nist
Copy link
Member

Closed as superseded by PR 59.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants