Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type stubs for all distributed modules. #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CruzR
Copy link

@CruzR CruzR commented Nov 1, 2018

Hi, I've implemented one of the solutions for adding type hints I discussed in #24. Would be nice if you could have a look and decide whether this seems acceptable to you.

@caseman
Copy link
Owner

caseman commented Nov 10, 2018

I don't hate the idea :)

I tried it out built with your change merged and nothing much seemed to happen when I run mypy -m noise. Is this mostly useful for dependent programs using noise?

@caseman
Copy link
Owner

caseman commented Nov 10, 2018

Also I notice there's a test.pyi included. That one seems a bit useless :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants