Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowing more than 9 types of policies/requests #239

Closed
etienne-lebrun opened this issue Jan 12, 2022 · 3 comments
Closed

allowing more than 9 types of policies/requests #239

etienne-lebrun opened this issue Jan 12, 2022 · 3 comments
Assignees
@hsluoyz
Labels
bug Something isn't working released

Comments

@etienne-lebrun
Copy link
Contributor

With the current implementations, policies above p10 and requests above r10 do not work.
This is because these regexps only keeps a single digit: 

pycasbin/casbin/util/util.py

Line 23 in a16bfaa

eval_p = re.search(r"\bp(\d?)\.", s)

pycasbin/casbin/util/util.py

Line 30 in a16bfaa

eval_r = re.search(r"\br(\d?)\.", s)

simply replacing the question mark by a star eval_p = re.search(r"\bp(\d*)\.", s) would allow to support more than 9 policies
@casbin-bot
Copy link
Member

@ffyuanda @Zxilly @techoner @elfisworking

@casbin-bot casbin-bot added the enhancement New feature or request label Jan 12, 2022
@leeqvip leeqvip added bug Something isn't working and removed enhancement New feature or request labels Jan 13, 2022
@leeqvip
Copy link
Member

leeqvip commented Jan 13, 2022

@etienne-lebrun It has been fixed.

github-actions bot pushed a commit that referenced this issue Jan 13, 2022
@semantic-release-bot
chore(release): 1.15.3 [skip ci]
9007c01 
## [1.15.3](v1.15.2...v1.15.3) (2022-01-13)

### Bug Fixes

* [#239](#239), not allowing more than 9 types of policies/requests ([dcf4392](dcf4392))
@github-actions
Copy link

🎉 This issue has been resolved in version 1.15.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hsluoyz @leeqvip @casbin-bot @etienne-lebrun